Skip to content

feat(number): add number/uint64/ctor#10908

Open
impawstarlight wants to merge 30 commits intostdlib-js:developfrom
impawstarlight:feature/uint64
Open

feat(number): add number/uint64/ctor#10908
impawstarlight wants to merge 30 commits intostdlib-js:developfrom
impawstarlight:feature/uint64

Conversation

@impawstarlight
Copy link
Copy Markdown
Contributor

@impawstarlight impawstarlight commented Mar 13, 2026

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Implements a constructor for creating 64-bit unsigned integers

Related Issues

Does this pull request have any related issues?

No

Questions

Any questions for reviewers of this pull request?

I've put various questions throughout the code as TODO comments

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

A lot of package structure stuff are missing and I committed with --no-verify since I wanted an early review. Also, how to run lint only for a specific package? I found filter env vars for running examples, tests, benchmarks but not for lint.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

I used Gemini and Copilot for discussing ideas, resolving errors and generating tests but the main implementation is fully done by hand.


@stdlib-js/reviewers

@impawstarlight
Copy link
Copy Markdown
Contributor Author

@kgryte I've worked out an initial implementation of the uint64/ctor

@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Mar 13, 2026

Coverage Report

Package Statements Branches Functions Lines
number/uint64/ctor $\color{red}986/1022$
$\color{green}+0.00%$
$\color{red}72/80$
$\color{green}+0.00%$
$\color{green}10/10$
$\color{green}+0.00%$
$\color{red}986/1022$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@impawstarlight impawstarlight marked this pull request as ready for review March 13, 2026 21:35
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 13, 2026
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants